feat(connectors): use TCP client for Flink sink#3657
Open
Standing-Man wants to merge 4 commits into
Open
Conversation
Signed-off-by: StandingMan <jmtangcs@gmail.com>
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Standing-Man
marked this pull request as draft
July 12, 2026 08:24
Standing-Man
force-pushed
the
flink-transport
branch
from
July 12, 2026 08:34
6e8359a to
f6acfb5
Compare
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Standing-Man
force-pushed
the
flink-transport
branch
from
July 12, 2026 08:42
f6acfb5 to
bb2e45f
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (41.93%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3657 +/- ##
============================================
+ Coverage 73.98% 74.02% +0.04%
- Complexity 937 956 +19
============================================
Files 1301 1301
Lines 147354 147239 -115
Branches 122911 122768 -143
============================================
- Hits 109013 108990 -23
+ Misses 34868 34777 -91
+ Partials 3473 3472 -1
🚀 New features to boost your workflow:
|
Standing-Man
marked this pull request as ready for review
July 12, 2026 08:52
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Contributor
|
@mmodzelewski and also please check this one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Rationale
The Flink connector used different transports for reading and writing messages. The source already used the native TCP client, while the sink sent messages through the HTTP client and hardcoded the HTTP port to 3000.
This caused the same IggyConnectionConfig to behave differently between the source and sink. It also required deployments to expose the HTTP API even when the configured Iggy endpoint used the TCP port.
The source and sink also parsed server addresses independently. The source relied on splitting the address by
:, while the sink used URI parsing. This produced inconsistent behavior and did not reliably support IPv6 or validate malformed endpoints.What changed?
Local Execution
Passed
Ran
AI Usage