Remove field id constraint on add files #2662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroko
force-pushed
the
remove-field_id-constraint-on-add_files
branch
2 times, most recently
from
0b599c6 to
d580102
Compare
jeroko
force-pushed
the
remove-field_id-constraint-on-add_files
branch
from
d580102 to
1addf60
Compare
Fokko
reviewed
Oct 27, 2025
pyiceberg/io/pyarrow.py
Outdated
Comment on lines
2637
to
2638
| requested_id_to_name = requested_schema._lazy_id_to_name | ||
| provided_id_to_name = provided_schema._lazy_id_to_name |
There was a problem hiding this comment.
Hey @jeroko Thanks for working on this, and adding this check.
However, I don't think we really care about the names; it is not a problem when they differ. However, if you add a file with a different schema, we can brick the table because of issues in the types. Should we check if the file contains the expected type for each of the IDs instead?
There was a problem hiding this comment.
@Fokko Right, we should not care about the names if the IDs are provided, and the mapping between the IDs and the types was already checked in the call to _check_schema_compatible at the end of this function. In that case I didn't really need to add any extra check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #2131
The PR relaxes the constraint that prevented adding any file with field IDs, and replaces it with a constraint that prevents adding files which contain field IDs that are inconsistent with the field IDs of the table. If the field IDs are compatible, then they can be added safely, if not, they will be rejected.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes