[Message Prioritization] - Add currentReplicaNumber metadata for message prioritization - #3043
Merged
xyuanlu merged 11 commits intoJul 14, 2025
Merged
Conversation
xyuanlu
reviewed
May 21, 2025
added 2 commits
May 27, 2025 16:45
csudharsanan
force-pushed
the
csudhars/message-prioritization
branch
from
May 27, 2025 23:46
95fc654 to
9b80190
Compare
xyuanlu
reviewed
Jun 5, 2025
Contributor
Author
|
New test results. |
…nts, renamed variables.
xyuanlu
reviewed
Jun 7, 2025
xyuanlu
reviewed
Jun 7, 2025
xyuanlu
reviewed
Jun 12, 2025
xyuanlu
reviewed
Jun 12, 2025
xyuanlu
reviewed
Jun 18, 2025
xyuanlu
reviewed
Jun 18, 2025
xyuanlu
reviewed
Jun 23, 2025
added 2 commits
June 23, 2025 13:46
xyuanlu
reviewed
Jun 25, 2025
xyuanlu
reviewed
Jun 25, 2025
…move filtering out second top state to top state
xyuanlu
reviewed
Jun 26, 2025
xyuanlu
reviewed
Jun 26, 2025
Contributor
|
Generally LGTM, please address format issue and some code clean |
Contributor
Author
Hey @xyuanlu updated the PR after the last comment. could you please approve this when you get a chance. thanks |
Contributor
|
LGTM. Thanks for addressing all comments :D |
Contributor
Author
|
Thanks for the review. The PR is approved by @xyuanlu . Final commit message: "Add currentReplicaNumber metadata for message prioritization by client". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
My PR addresses the following Helix issues and references them in the PR description:
Fixes Prioritize upward state transitions to improve recovery time #3042
Description
Here are some details about my PR, including screenshots of any UI changes:
Enhances Helix's message generation phase to prioritize upward state transitions from non-second top states to second top or top states.
Tests
The following tests are written for this issue:
TestPrioritizationMessageGeneration
The following is the result of the "mvn test" command on the appropriate module:
Changes that Break Backward Compatibility (Optional)
N/A
Documentation (Optional)
N/A
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)