-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29689 Upgrade the website #7419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| The website will be available at `http://localhost:3000`. | ||
|
|
||
| **Deploy to any platform supporting Docker:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we're going to use this in production
|
Generally, we need to figure out how this integrates into the existing Website update workflow. |
This comment has been minimized.
This comment has been minimized.
@Apache9 , can you help us with that? Also, would you share your views on this website redesign proposal? |
|
I'm OK with the new design, looks good. What we pushed to the hbase-site repo will be published to hbase.apache.org. The .asf.yaml can control which branch to publish, now we use asf-site branch. So maybe we could manually push our new site to another branch, try publishing it and see the result. If we think it is OK, then we can working on change the current publish website job to do it automatically. And since the old branch is still there, if there are something wrong, we can switch back to the old web site. |
PDavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, especially for the detailed README. Really nice. 👍
Just that the type check failed in the PR build with some strange "Error: Cannot find native binding. " error.
Also we should add the ASF licence to the top of every source file and the spotless check (formatter) is complaining.
You can check the comments left by the Apache HBase build bot.
Built based on apache/hbase#7419 Cleaned up old pages.
Thanks @Apache9, great idea! 👍 I built the new website locally and pushed to the website repo on this branch: https://github.com/apache/hbase-site/tree/asf-site-staging According to https://github.com/apache/infrastructure-asfyaml#staging-a-web-site-preview-domain we can stage (live preview) another branch, so opened a new PR for staging this new website branch: Can you please have a look? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
PDavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks Yurii for the additional improvements, looks really nice. 💪
I found some very minor issues.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
PDavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, looks good to me.
Would be great if the PR build could go through. Maybe rebasing on master could help.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
06f49e6 to
b083ec3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
OK, now the preview website is live at: EDIT: The website might be unavailable as it takes a lot of time to check out the site git repo. I asked the ASF Infra on Slack. |
|
It's still not available. |
Yes, unfortunately. Yesterday there was a timeout checking out the git repo, The ASF Infra team re-triggered it but did not saw why it is not working yet. |
|
OK, now https://hbase-beta.staged.apache.org/ is working. |
Looks good. We could send an email to the mailing list to attract more feedbacks. |
|
Site looks great. Just wondering how do we handle dynamic content like teams page? I see its hardcoded here. I think its important to do an audit and call out all such discrepancies in this version of site. |
PDavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some minor issues in links under the "Documentation and API" menu:
- In "1.4 Documentation" we have a User API (Test) link in this new website but that does not exists for this version (HTTP 404 - Not Found). On our current production site we have a Developer API link there instead.
- In "2.3 Documentation" the link for "Reference Guide (PDF)" is not correct. It is https://hbase.apache.org/2.3/book.pdf but it should be https://hbase.apache.org/2.3/apache_hbase_reference_guide.pdf
- In "2.4 Documentation" the link for "Reference Guide (PDF)" is not correct. It is https://hbase.apache.org/2.4/book.pdf but it should be https://hbase.apache.org/2.4/apache_hbase_reference_guide.pdf
b083ec3 to
c68e92d
Compare
|
@NihalJain thanks for the review. Now we generate the @PDavid Thanks again, I fixed the issues. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
The improved, basically new, Apache HBase website.
Demo: https://hbase-landing.vercel.app/
The detailed description is available in
README.mdBrief overview: