-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29667 Correct block priority to SINGLE on the first write to the bucket cache #7399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
wchevreuil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this and submitting a fix, @Huginn-kio ! It definitely looks like a bug. Can we add a simple UT for this on TestBucketCache? It should simply validate that a BucketEntry gets created with SINGLE priority, then once access() is called, its priority changes to MULTI.
This comment has been minimized.
This comment has been minimized.
|
@Huginn-kio , FYI, there were some UT failures on the latest precommit build, but I think it's not related to your changes, so I'm trying another build run just to attempt a green check. I'll keep you posted. |
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…e bucket cache (#7399) Reviewed by: Kota-SH <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
…e bucket cache (apache#7399) Reviewed by: Kota-SH <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
…e bucket cache (#7399) Reviewed by: Kota-SH <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
…e bucket cache (#7399) Reviewed by: Kota-SH <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
HBASE-29667 Correct block priority to SINGLE on the first write to the bucket cache