Skip to content

Conversation

@Huginn-kio
Copy link
Contributor

HBASE-29667 Correct block priority to SINGLE on the first write to the bucket cache

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and submitting a fix, @Huginn-kio ! It definitely looks like a bug. Can we add a simple UT for this on TestBucketCache? It should simply validate that a BucketEntry gets created with SINGLE priority, then once access() is called, its priority changes to MULTI.

@Apache-HBase

This comment has been minimized.

@wchevreuil
Copy link
Contributor

@Huginn-kio , FYI, there were some UT failures on the latest precommit build, but I think it's not related to your changes, so I'm trying another build run just to attempt a green check. I'll keep you posted.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 51s master passed
+1 💚 compile 3m 32s master passed
+1 💚 checkstyle 1m 1s master passed
+1 💚 spotbugs 1m 42s master passed
+1 💚 spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 20s the patch passed
+1 💚 compile 3m 28s the patch passed
+1 💚 javac 3m 28s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 0s the patch passed
+1 💚 spotbugs 1m 45s the patch passed
+1 💚 hadoopcheck 12m 23s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
42m 17s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7399/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7399
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 240aeae9980a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6ffe681
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7399/9/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 19s master passed
+1 💚 compile 0m 59s master passed
+1 💚 javadoc 0m 31s master passed
+1 💚 shadedjars 6m 58s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 8s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 javadoc 0m 34s the patch passed
+1 💚 shadedjars 7m 10s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 218m 53s /patch-unit-hbase-server.txt hbase-server in the patch failed.
249m 9s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7399/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7399
Optional Tests javac javadoc unit compile shadedjars
uname Linux 15f50de43660 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6ffe681
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7399/9/testReport/
Max. process+thread count 4358 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7399/9/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil wchevreuil merged commit 9c16588 into apache:master Nov 4, 2025
1 check failed
wchevreuil pushed a commit that referenced this pull request Nov 4, 2025
…e bucket cache (#7399)

Reviewed by: Kota-SH <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Nov 4, 2025
…e bucket cache (apache#7399)

Reviewed by: Kota-SH <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
wchevreuil pushed a commit that referenced this pull request Nov 5, 2025
…e bucket cache (#7399)

Reviewed by: Kota-SH <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
wchevreuil pushed a commit that referenced this pull request Nov 5, 2025
…e bucket cache (#7399)

Reviewed by: Kota-SH <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants