HBASE-29545 Remove usage of Unsafe.defineClass

[richardantal]

No description provided.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	spotbugs	0m 0s		spotbugs executables are not available.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+1 💚	mvninstall	0m 57s		master passed
+1 💚	compile	0m 6s		master passed
+1 💚	checkstyle	0m 6s		master passed
+1 💚	javadoc	0m 6s		master passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 8s		the patch passed
+1 💚	compile	0m 6s		the patch passed
+1 💚	javac	0m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-1 ❌	checkstyle	0m 3s	/results-checkstyle-hbase-unsafe.txt	hbase-unsafe: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	javadoc	0m 5s		the patch passed
			_ Other Tests _
+1 💚	unit	0m 6s		hbase-unsafe in the patch passed.
+1 💚	asflicense	0m 6s		The patch does not generate ASF License warnings.
		3m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-148/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#148
Optional Tests	dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
uname	Linux 840e778eae74 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-148/yetus-precommit-check/src/.yetus/personality.sh
git revision	master / a267a9c
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-148/1/testReport/
Max. process+thread count	63 (vs. ulimit of 2000)
modules	C: hbase-unsafe U: hbase-unsafe
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-148/1/console
versions	git=2.34.1 maven=called
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 7s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	spotbugs	0m 0s		spotbugs executables are not available.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ master Compile Tests _
+1 💚	mvninstall	0m 53s		master passed
+1 💚	compile	0m 7s		master passed
+1 💚	checkstyle	0m 6s		master passed
+1 💚	javadoc	0m 6s		master passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 6s		the patch passed
+1 💚	compile	0m 5s		the patch passed
+1 💚	javac	0m 5s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 3s		the patch passed
+1 💚	javadoc	0m 5s		the patch passed
			_ Other Tests _
+1 💚	unit	0m 7s		hbase-unsafe in the patch passed.
+1 💚	asflicense	0m 6s		The patch does not generate ASF License warnings.
		4m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-148/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#148
Optional Tests	dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile
uname	Linux a31e7ab6796d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-Thirdparty-PreCommit_PR-148/yetus-precommit-check/src/.yetus/personality.sh
git revision	master / dd15db2
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-148/2/testReport/
Max. process+thread count	67 (vs. ulimit of 2000)
modules	C: hbase-unsafe U: hbase-unsafe
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-148/2/console
versions	git=2.34.1 maven=called
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[richardantal]

@stoty , @Apache9
I searched for usages in and did not find any place where it was used.
Can we remove these functions?

[richardantal]

It would help if we want to build hbase-thirdparty with only java 17

[richardantal]

should we adapt these functions to use java.lang.invoke.MethodHandles.Lookup.defineClass instead?

[stoty]

should we adapt these functions to use java.lang.invoke.MethodHandles.Lookup.defineClass instead?

That would alleviate concerns about removing methods in a patch release.

[richardantal]

The problem is that Lookup.defineClass is only available since JDK 9