HBASE-29475 [hbase-thirdparty] Add spotless in pre commit check #145

NihalJain · 2025-07-28T05:16:18Z

No description provided.

NihalJain · 2025-07-28T07:05:27Z

Need to see what's going on here, will check back later

NihalJain · 2025-08-04T13:21:06Z

Ah this works w/o any change, maybe build failed due to transient error.

NihalJain · 2025-08-04T13:33:07Z

Spotless is not triggered, let me check

Apache-HBase · 2025-08-04T14:17:21Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/10/console in case of problems.

Apache-HBase · 2025-08-04T14:18:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 3s		Maven dependency ordering for branch
+1 💚	spotless	0m 5s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 3s		Maven dependency ordering for patch
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotless	0m 4s		patch has no errors when running spotless:check.
			_ Other Tests _
+0 🆗	asflicense	0m 0s		ASF License check generated no output?
		0m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/10/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#145
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless
uname	Linux decc83d7ed8d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `1316b7f`
Max. process+thread count	48 (vs. ulimit of 2000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/10/console
versions	git=2.34.1 maven=called shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-08-04T14:19:43Z

Cool spotless is integrated now; let me add a dummy spotless issue to trigger build failure path

NihalJain · 2025-08-04T14:25:19Z

Added dummy spotless issue for test. Build should fail now!

Apache-HBase · 2025-08-04T14:34:43Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/12/console in case of problems.

Apache-HBase · 2025-08-04T14:37:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	spotbugs	0m 0s		spotbugs executables are not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ master Compile Tests _
+1 💚	mvninstall	0m 41s		master passed
+1 💚	compile	0m 7s		master passed
+1 💚	checkstyle	0m 4s		master passed
+1 💚	javadoc	0m 5s		master passed
-1 ❌	spotless	0m 3s		branch has 16 errors when running spotless:check, run spotless:apply to fix.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 8s		the patch passed
+1 💚	compile	0m 6s		the patch passed
+1 💚	javac	0m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-1 ❌	checkstyle	0m 3s	/results-checkstyle-hbase-noop-htrace.txt	hbase-noop-htrace: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	0m 5s		the patch passed
-1 ❌	spotless	0m 2s		patch has 31 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	unit	0m 36s		hbase-noop-htrace in the patch passed.
-1 ❌	asflicense	0m 4s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		2m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/12/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#145
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac javadoc unit spotbugs checkstyle compile
uname	Linux 840406ead2a4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `66f48b4`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/12/artifact/yetus-precommit-check/output/branch-spotless.txt
spotless	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/12/artifact/yetus-precommit-check/output/patch-spotless.txt
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/12/testReport/
Max. process+thread count	418 (vs. ulimit of 2000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/12/console
versions	git=2.34.1 maven=called shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-08-04T14:38:47Z

Great build failed as expected. Reverting dummy change 66f48b4

NihalJain · 2025-08-04T14:40:07Z

@Apache9 are we good to take this?

Apache-HBase · 2025-08-04T14:59:53Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/14/console in case of problems.

Apache-HBase · 2025-08-04T15:00:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 3s		Maven dependency ordering for branch
+1 💚	spotless	0m 4s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 3s		Maven dependency ordering for patch
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotless	0m 4s		patch has no errors when running spotless:check.
			_ Other Tests _
+0 🆗	asflicense	0m 0s		ASF License check generated no output?
		0m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/14/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#145
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless
uname	Linux 2c7957019cf7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/jenkins/hbase-personality.sh
git revision	master / `1316b7f`
Max. process+thread count	49 (vs. ulimit of 2000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-145/14/console
versions	git=2.34.1 maven=called shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.