Skip to content

fix(udf): handle Integer.MIN_VALUE in Substr function #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SYaoJun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(udf): handle Integer.MIN_VALUE in Substr function #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ow-dsl/geaflow-dsl-plan/src/main/java/org/apache/geaflow/dsl/udf/table/string/Substr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ public String eval(String str, Integer pos, Integer length) {
if (str == null || pos == null || length == null) {
return null;
}
if (pos == Integer.MIN_VALUE) {
return str;
}
if ((Math.abs(pos) > str.length())) {
return str;
}
Expand Down Expand Up @@ -64,6 +67,9 @@ public BinaryString eval(BinaryString str, Integer pos, Integer length) {
if (str == null || pos == null || length == null) {
return null;
}
if (pos == Integer.MIN_VALUE) {
return null;
Copy link
Contributor

@Leomrlin Leomrlin Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the String and BinaryString versions inconsistent?

}
if (Math.abs(pos) > str.getLength()) {
return null;
}
Expand Down
13 changes: 13 additions & 0 deletions ...flow-dsl/geaflow-dsl-plan/src/test/java/org/apache/geaflow/dsl/udf/string/SubstrTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,17 @@ public void test() {
Assert.assertEquals(sb.eval(BinaryString.fromString("Facebook"), -5).toString(), "ebook");
Assert.assertEquals(sb.eval(BinaryString.fromString("Facebook"), 5, 1).toString(), "b");
}

@Test
public void testIntegerMinValue() {
Substr sb = new Substr();

// Test Integer.MIN_VALUE for String version
Assert.assertEquals(sb.eval("hello", Integer.MIN_VALUE, 1), "hello");
Copy link
Contributor

@Leomrlin Leomrlin Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this usage not common in SQL?

Assert.assertEquals(sb.eval("hello", Integer.MIN_VALUE), "hello");

// Test Integer.MIN_VALUE for BinaryString version
Assert.assertNull(sb.eval(BinaryString.fromString("hello"), Integer.MIN_VALUE, 1));
Assert.assertNull(sb.eval(BinaryString.fromString("hello"), Integer.MIN_VALUE));
}
}