feat: implement GraphSAGE algorithm based on GeaFlow inference framework #679
Open
kitalkuyo-gita wants to merge 24 commits intoapache:masterfrom
Open
feat: implement GraphSAGE algorithm based on GeaFlow inference framework #679kitalkuyo-gita wants to merge 24 commits intoapache:masterfrom
kitalkuyo-gita wants to merge 24 commits intoapache:masterfrom
Conversation
- Replace 'var' with 'IVertex<Object, List<Double>>' in GraphSAGECompute.java - Fix compilation error in FeatureCollector.getVertexFeatures method - Ensure compatibility with JDK 8 (var is Java 10+ feature) - Resolve CI build failure on GitHub Actions This change fixes the symbol not found error that occurred during Maven compilation on JDK 8. The var keyword was introduced in Java 10 as local variable type inference, but this project targets JDK 8.
… compatibility - Replace 'new FileWriter(File, Charset)' with 'new OutputStreamWriter(new FileOutputStream(File), Charset)' - Fix compilation errors in GraphSAGEInferIntegrationTest at lines 400, 547, and 555 - Ensure JDK 8 compatibility (FileWriter(File, Charset) is Java 11+ feature) - Resolve test compilation failure on GitHub Actions CI This change fixes three occurrences where FileWriter was constructed with Charset parameter, which is not available in JDK 8. Using OutputStreamWriter wrapper around FileOutputStream provides the same UTF-8 encoding support while maintaining JDK 8 compatibility.
- Add Python 3.9 setup step using actions/setup-python@v4 - Install requirements from geaflow-dsl-plan/src/main/resources/requirements.txt - Include pip cache to speed up subsequent builds - Verify torch installation with pip list - Enable full GraphSAGE integration tests in CI This ensures all Python dependencies (torch, numpy, etc.) are available for running the GraphSAGE integration tests, preventing ModuleNotFoundError failures in CI.
kitalkuyo-gita
force-pushed
the
issue-677
branch
from
77ba980 to
c4c5480
Compare
This is an empty commit to trigger GitHub Actions CI pipeline. Changes being tested: - Python 3.9 setup in CI workflow - Automatic installation of requirements.txt (torch, numpy, etc.) - JDK 8 compatibility fixes (var keyword, FileWriter) Expected result: GraphSAGE integration tests should pass with PyTorch available.
- Add Python 3.9 setup step using actions/setup-python@v4 - Install requirements from geaflow-dsl-plan/src/main/resources/requirements.txt - Include pip cache to speed up subsequent builds - Verify torch installation with pip list - Enable full GraphSAGE integration tests in JDK 11 CI This mirrors the Python dependency installation from JDK 8 workflow and ensures GraphSAGE tests can run properly on both JDK versions.
…tyle violations - Remove unused import: ConnectedComponents - Remove unused import: LabelPropagation - Remove unused import: Louvain These imports were added during merge but not actually used in the code. Checkstyle was failing with UnusedImports warnings.
- Add import for ConnectedComponents class - Register ConnectedComponents.class in buildInSqlFunctions list - Fix GQLAlgorithmTest.testAlgorithmConnectedComponents test failure The ConnectedComponents algorithm was incorrectly removed in previous checkstyle fix, causing 'Cannot load graph algorithm implementation of cc' error.
- Add import for LabelPropagation class - Register LabelPropagation.class in buildInSqlFunctions list - Fix GQLAlgorithmTest.testAlgorithmLabelPropagation test failure The LabelPropagation (lpa) algorithm was missing from the function table, causing 'Cannot load graph algorithm implementation of lpa' error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Related to issue-677
How was this PR tested?