[FLINK-37427] Fix incorrect NPE message in StandaloneHaServices constructor

[lurongjiang]

What is the purpose of the change

developers receive unhelpful error messages when parameters are null.

Brief change log

Replace checkNotNull(clusterRestEndpointAddress, clusterRestEndpointAddress) with checkNotNull(clusterRestEndpointAddress, "clusterRestEndpointAddress") to ensure the exception message clearly identifies the null parameter.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no

[flinkbot]

CI report:

• f810389 Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[davidradl]

nit: could we have a unit test, to check that null values are handled as expected. As this is a trivial change - it is your call as to whether you add this.

[davidradl]

nit: we could correct the javadoc and add this parameter while we are here.

[lurongjiang]

Thank you for the feedback! I apologize for the confusion.
I've closed this PR because my branch had fallen significantly behind upstream/master, which caused a large number of unintended file changes when I tried to rebase. To resolve this, I've created a new, clean PR with a fresh branch based on the latest master: #27258.
The new PR contains all the requested changes (the NPE fix and the unit test). Could you please review the new one instead? Thanks again for your time!
Best regards

[davidradl]

approving

• raised some nits but these are nice to haves and the change looks good.

[github-actions]

This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.