-
Notifications
You must be signed in to change notification settings - Fork 19.8k
fix(datalabel): hideOverlap not work on emphasis state #21233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! |
49cc8df to
abd13df
Compare
|
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21233@88eb99f |
|
@100pah Could you help to review the PR? Thanks! |
|
@plainheart @pissang Could you help to review the PR? Thanks! |
|
@Justin-ZS Hi, I've voted you to be a committer of Apache ECharts due to your continuous contribution. Can you provide an Email address for me to send our invitation. Please add my We-chat oviliazhang with a note "Justin-ZS" so that I can add you to our committer group. Thanks! |
Thank you! I’m so happy to hear that! |
Brief Information
This pull request is in the type of:
What does this PR do?
Fix hideOverlap not working on emphasis state for data labels.
Fixed issues
Details
Before: What was the problem?
When data labels have
hideOverlapenabled, all overlapping labels are forcibly displayed during emphasis state (hover or other emphasis triggers), completely ignoring the overlap detection settings. This causes dense label overlapping and affects readability.After: How does it behave after the fixing?
Fix Method:
EmphasisManagerclass to manage label overlap during emphasis statehideOverlapfunction to support pre-ordered mode, emphasis state labels also follow overlap rulesDocument Info
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information