Feat: Enhance service method retrieval and invocation features by Similarityoung · Pull Request #1429 · apache/dubbo-admin

Similarityoung · 2026-03-08T09:44:20Z

Description

This PR adds structured service method introspection and generic invoke capabilities to Dubbo Admin console, and tightens the generic invoke contract to rely on provider metadata instead of client-supplied parameter types.

What changed

Added console APIs for service method discovery:
- GET /api/v1/service/methods
- GET /api/v1/service/method/detail
- POST /api/v1/service/generic/invoke
Extended method detail response to include:
- signature
- method-related types closure derived from provider metadata
Changed generic invoke request contract:
- removed client-provided parameterTypes
- added signature
- backend now resolves authoritative parameterTypes from provider metadata by service + methodName + signature
Added stricter overload handling:
- if signature is omitted and the method is overloaded, return InvalidArgument
- if only fallback metadata exists without structured Methods/Types, return a clear error instead of guessing
Refactored generic invoke argument decoding:
- switched request args to []json.RawMessage
- decode values after metadata resolution based on target parameter types
- supports numeric primitives, primitive arrays, object arrays, JVM array descriptors, and char
Included a small ZK governor compatibility fix when creating nodes

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

… request model

…ovider app name in ServiceMethodsReq

…ture retrieval

…t struct

Copilot

Pull request overview

This PR adds service method introspection endpoints and a metadata-driven generic invocation flow to the Dubbo Admin console, shifting generic invoke parameter type resolution from client input to provider metadata.

Changes:

Added console APIs for listing service methods, fetching method details (including signature/types closure), and performing generic invoke.
Implemented provider-metadata-based overload resolution via methodName + signature and refactored generic invoke argument decoding using []json.RawMessage.
Updated ZK node creation flag usage and bumped/adjusted Go module dependencies to support the new generic invoke implementation.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/governor/zk/governor.go	Adjusts ZK node creation flags for compatibility.
pkg/console/service/service_generic_invoke_decode.go	Adds typed argument decoding helpers for generic invoke based on resolved parameter types.
pkg/console/service/service_generic_invoke.go	Implements generic invoke flow: metadata lookup, overload resolution, target selection, and RPC invocation.
pkg/console/service/service.go	Adds provider-metadata-backed method discovery and method detail/type-closure building.
pkg/console/router/router.go	Registers new service routes for methods, method detail, and generic invoke under `/api/v1/service`.
pkg/console/model/service.go	Adds request/response models for method discovery, method detail, and generic invoke (including `signature` and raw args).
pkg/console/handler/service.go	Adds handlers wiring the new endpoints to service layer functions.
go.mod	Updates dubbo-go dependency and adds hessian2 + other indirects needed for new invoke path.
go.sum	Updates dependency checksums accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/console/service/service.go

Copilot · 2026-03-08T09:50:00Z

pkg/console/service/service_generic_invoke.go

+var invokeGenericServiceRPC = func(callCtx context.Context, invocation genericInvocation) (any, error) {
+	ins, err := dubbo.NewInstance(dubbo.WithName(genericInvokeInstanceName))
+	if err != nil {
+		return nil, err
+	}
+
+	cli, err := ins.NewClient(
+		client.WithClientProtocolTriple(),
+		client.WithClientSerialization(dubboconstant.Hessian2Serialization),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	svc, err := cli.NewGenericService(
+		invocation.ServiceName,
+		client.WithURL(invocation.URL),
+		client.WithVersion(invocation.Version),
+		client.WithGroup(invocation.Group),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	return svc.Invoke(callCtx, invocation.MethodName, invocation.ParameterTypes, invocation.Args)
+}


invokeGenericServiceRPC creates a new Dubbo instance + client + generic service on every invocation. This is likely expensive and may also accumulate background resources (connections, goroutines) depending on the dubbo-go implementation. Consider initializing and reusing a singleton instance/client (and, if possible, a cached generic service per service/version/group) with proper lifecycle management instead of rebuilding everything per request.

Optimization can be made in the future

copilot这里说的有道理，这里可以在代码里记一个todo，加上client的缓存

pkg/console/service/service_generic_invoke.go

pkg/console/service/service_generic_invoke_decode.go

Similarityoung · 2026-03-08T09:57:46Z

Code review

Found 1 issue:

Generic invoke leaks raw upstream/internal RPC errors back to the client instead of following the console's usual stable InternalError pattern. The rest of pkg/console/service returns fixed user-facing messages and logs the cause server-side, but this new path returns err.Error() directly, which can expose transport/provider details and make API responses inconsistent.

dubbo-admin/pkg/console/service/service_generic_invoke.go

Lines 148 to 152 in c04698c

    
           if err != nil { 
        
           	logger.Errorf("generic invoke failed, service=%s, method=%s, providerApp=%s, target=%s:%d, cause: %v", 
        
           		req.ServiceName, req.MethodName, providerAppName, target.instance.Spec.Ip, target.port, err) 
        
           	return nil, bizerror.New(bizerror.InternalError, err.Error()) 
        
           }

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

…rameter count validation

…viceGeneric in ServiceGenericInvoke

robocanic

Great Work! I left some comments and hope you can discuss them with me.

robocanic · 2026-03-08T13:13:23Z

pkg/console/model/service.go

+}
+
+func (s *ServiceGenericInvokeReq) Validate() error {
+	s.Mesh = strings.TrimSpace(s.Mesh)


suggestrion: 这里都可以简化用lancet的工具类strutil.isBlank来判断

robocanic · 2026-03-08T13:17:36Z

pkg/console/service/service.go

+	return filtered, nil
+}
+
+func matchesServiceMethodsReq(metadata *meshresource.ServiceProviderMetadataResource, req model.ServiceMethodsReq) bool {


Suggestion：这里的过滤其实可以在查询DB的时候做掉。可以在ServiceProviderMetadata的index(pkg/core/store/index/service_provider_metadata.go)里面新增对于serviceKey（serviceName:version:group）的一个索引，这样就不用在上层过滤了。

robocanic · 2026-03-08T13:29:48Z

pkg/console/service/service.go

+		}
+	}
+
+	for methodName := range fallbackMethodNames {


Question：这段逻辑有点没看懂，可以写写注释

当前实现会优先使用 Spec.Methods 里的结构化定义；只有当结构化方法信息缺失时，才退回到 parameters["methods"] 里提取方法名做兜底展示，避免 fallback 覆盖掉更完整的签名/参数类型信息。

robocanic · 2026-03-08T13:34:26Z

pkg/console/service/service_generic_invoke.go

+		return nil, err
+	}
+
+	cli, err := ins.NewClient(


Question：这里是不是应该根据目标service的协议和序列化来new client？

这里其他协议我还没做测试，我记得序列化好像只有 Hessian2，我回头看看。

robocanic · 2026-03-08T13:35:18Z

pkg/console/service/service_generic_invoke.go

+var invokeGenericServiceRPC = func(callCtx context.Context, invocation genericInvocation) (any, error) {
+	ins, err := dubbo.NewInstance(dubbo.WithName(genericInvokeInstanceName))
+	if err != nil {
+		return nil, err
+	}
+
+	cli, err := ins.NewClient(
+		client.WithClientProtocolTriple(),
+		client.WithClientSerialization(dubboconstant.Hessian2Serialization),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	svc, err := cli.NewGenericService(
+		invocation.ServiceName,
+		client.WithURL(invocation.URL),
+		client.WithVersion(invocation.Version),
+		client.WithGroup(invocation.Group),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	return svc.Invoke(callCtx, invocation.MethodName, invocation.ParameterTypes, invocation.Args)
+}


copilot这里说的有道理，这里可以在代码里记一个todo，加上client的缓存

…enhance service provider metadata indexing

sonarqubecloud · 2026-03-08T14:38:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Similarityoung added 7 commits March 4, 2026 20:06

feat: add endpoint to retrieve service method names and corresponding…

6fc5dde

… request model

feat: add endpoint and logic to retrieve service method details

43725cd

feat: trim whitespace from service name, mesh, group, version, and pr…

1f14a6d

…ovider app name in ServiceMethodsReq

feat: enhance service method handling with overload support and signa…

4e19307

…ture retrieval

feat: add generic service invocation support

9c6ec77

feat: refactor triple RPC instance selection to use a dedicated targe…

59fc988

…t struct

feat: remove obsolete service methods test file

c04698c

Copilot AI review requested due to automatic review settings March 8, 2026 09:44

Copilot started reviewing on behalf of Similarityoung March 8, 2026 09:44 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Similarityoung added 2 commits March 8, 2026 19:31

feat: improve error handling in generic service invocation and add pa…

e6b7660

…rameter count validation

feat: remove unnecessary variable and directly call service.InvokeSer…

4d87df4

…viceGeneric in ServiceGenericInvoke

robocanic reviewed Mar 8, 2026

View reviewed changes

feat: improve query validation by using strutil for blank checks and …

a155f06

…enhance service provider metadata indexing

Conversation

Similarityoung commented Mar 8, 2026

Description

What changed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Similarityoung commented Mar 8, 2026

Code review

Uh oh!

robocanic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 8, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants