-
Notifications
You must be signed in to change notification settings - Fork 254
feat: Support ANSI mode avg expr #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Support ANSI mode avg expr #2817
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
============================================
+ Coverage 56.12% 59.07% +2.94%
- Complexity 976 1459 +483
============================================
Files 119 165 +46
Lines 11743 15059 +3316
Branches 2251 2504 +253
============================================
+ Hits 6591 8896 +2305
- Misses 4012 4894 +882
- Partials 1140 1269 +129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@coderfender You can merge latest from main to fix the current CI failures |
5192933 to
33b0b2f
Compare
|
@andygrove , Thank you . I rebased my feature branch with main. Please kick off CI whenever you get a chance . Thank you |
|
@andygrove , fixed issues with formatting and an unused import. Please kickoff the CI whenever you get a chance . Thank you |
Which issue does this PR close?
Closes #531
Rationale for this change
Support ANSI eval mode (for integer types) for average expression
What changes are included in this PR ?
Infas a valid output and doesnt necessarily throw an exception, we follow the same approach in comet as well (essentially making eval mode's redundant for numeric inputs)How are these changes tested?