fix: Fall back to Spark for MakeDecimal with unsupported input type #2815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
============================================
+ Coverage 56.12% 59.10% +2.97%
- Complexity 976 1475 +499
============================================
Files 119 165 +46
Lines 11743 15068 +3325
Branches 2251 2508 +257
============================================
+ Hits 6591 8906 +2315
- Misses 4012 4895 +883
- Partials 1140 1267 +127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
reviewed
Nov 22, 2025
| } | ||
| let result_type = DataType::Decimal128(precision, scale); | ||
| ColumnarValue::Array(a) => match a.data_type() { | ||
| DataType::Int64 => { |
Contributor
There was a problem hiding this comment.
should we also support Int32? 🤔
martin-g
reviewed
Nov 24, 2025
| SQLConf.ANSI_ENABLED.key -> "false", | ||
| SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false", | ||
| CometConf.getExprAllowIncompatConfigKey(classOf[Sum]) -> "true", | ||
| CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_NATIVE_ICEBERG_COMPAT, |
Member
There was a problem hiding this comment.
Are all settings needed for this test ? E.g. Sum and Iceberg compat look unrelated ?
|
|
||
| override def getSupportLevel(expr: MakeDecimal): SupportLevel = { | ||
| expr.child.dataType match { | ||
| case _: LongType => Compatible() |
Member
There was a problem hiding this comment.
Suggested change
| case _: LongType => Compatible() | |
| case LongType => Compatible() |
because LongType is an object/singleton
| checkSparkAnswerAndFallbackReason(df1, "Unsupported input data type: IntegerType") | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
IMO it would be useful to add a positive test too - with LongType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2813
Rationale for this change
What changes are included in this PR?
How are these changes tested?