Enhance reduce limit 2 #5728
Enhance reduce limit 2 #5728
Conversation
| iolist_to_binary(io_lib:format(Fmt, [InSize, OutSize])). | ||
|
|
||
| reduce_limit_threshold() -> | ||
| config:get_integer("query_server_config", "reduce_limit_threshold", 4906). |
There was a problem hiding this comment.
Reducing it back to the built-in intended value of 4096 could break some views if they were right on the edge, maybe just make both 5000 (4096 plus some overhead)?
There was a problem hiding this comment.
I consolidated the setting into one (passing reduce_limit_threshold to the view server config) and chose the most generous of the two (accidentally) in play.
There was a problem hiding this comment.
I just meant that 4906 is a whacky value, might as well round it up to 5000. It was supposed to be a 4096
share/server/views.js
Outdated
| } else { | ||
| throw(["error", "reduce_overflow_error", log_message]); | ||
| }; | ||
| throw(["error", "reduce_overflow_error", log_message]); |
There was a problem hiding this comment.
If users used log and node-local views this will ignore the log and break their view and start enforcing the reduce limit. Not sure the chance of those things happening: both 1) using local dbs and views and 2) setting it to log but it's worth pointing it out at least
rnewson
force-pushed
the
enhance_reduce_limit-2
branch
from
00c4f22 to
a1a474b
Compare
2 participants
Overview
Testing recommendations
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder