(android): Added ability to setCancelable #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set local final variable for isCancelable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
When user taps outside the dialog in Android, it cancels the dialog. This may not be the expected behaviour for some users, since the user has not tap any of the buttons. Resulting in confusion for some users.
This change allows the developer to set globally, whether dialog should be cancelable
Description
Changes are added specifically for Android platform.
Added a property - isCancelable, to Notification.java class that controls whether new dialogs are cancelable.
Default is true, so the change is backward compatible
Added a function - setCancelable(enable), to set the isCancelable property