Fix KVM incremental volume snapshot migration between secondary storages

[hsato03]

Description

ACS allows data to be migrated from one secondary storage to another; however, this process disregards incremental volume snapshots created using the KVM hypervisor.

Since then, the migration process has been extended to also allow the migration of these resources.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

N°	Test	API	Result	Expected result (Y/N)
1	Migrate a single incremental volume snapshot	migrateResourceToAnotherSecondaryStorage	The snapshot, along with its checkpoint file, was migrated to the destination storage, and its child snapshot, which remained in the old storage, was rebased onto the snapshot in the new storage	Y
2	Migrate the entire chain of incremental volume snapshots to another secondary storage	migrateSecondaryStorageData	All snapshots were migrated and the chain was correctly updated with the files from the new storage	Y
3	Migrate a chain of incremental volume snapshots split between 2 secondary storages	migrateSecondaryStorageData	The chain was updated based on existing snapshots in the destination storage and the new file from the migrated snapshots	Y

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0.72202% with 275 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.55%. Comparing base (6dc259c) to head (f185688).

Files with missing lines	Patch %	Lines
...apshotsBetweenSecondaryStoragesCommandWrapper.java	1.08%	91 Missing ⚠️
...tack/engine/orchestration/StorageOrchestrator.java	0.00%	87 Missing ⚠️
...ack/engine/orchestration/DataMigrationUtility.java	0.00%	31 Missing ⚠️
...grateSnapshotsBetweenSecondaryStoragesCommand.java	0.00%	24 Missing ⚠️
...he/cloudstack/storage/snapshot/SnapshotObject.java	0.00%	17 Missing ⚠️
...java/org/apache/cloudstack/utils/qemu/QemuImg.java	0.00%	12 Missing ⚠️
.../MigrateBetweenSecondaryStoragesCommandAnswer.java	0.00%	9 Missing ⚠️
...tack/storage/snapshot/SnapshotDataFactoryImpl.java	0.00%	3 Missing ⚠️
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12086      +/-   ##
============================================
- Coverage     17.55%   17.55%   -0.01%     
- Complexity    15535    15540       +5     
============================================
  Files          5911     5914       +3     
  Lines        529359   529609     +250     
  Branches      64655    64674      +19     
============================================
+ Hits          92949    92982      +33     
- Misses       425952   426168     +216     
- Partials      10458    10459       +1     

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.62% <0.72%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15785

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15805

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14849)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51711 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12086-t14849-kvm-ol8.zip
Smoke tests completed. 149 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	Failure	381.24	test_vpc_vpn.py