-
Notifications
You must be signed in to change notification settings - Fork 119
Calico sample — require BGP and correct indenting #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Correcting indentation for the sample CNI config
added note for BGP requirement
@blueorangutan docbuild |
@kiranchavala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/574. (QA-JID 443) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A CNI framework has also been added which provides end users the flexibility to use the CNI plugin of their choice. The CNI framework internally leverages the managed User data feature provided by CloudStack. | ||
|
||
Sample Calico CNI configuration data used which is appended to the existing Kubernetes control node user data is: | ||
**NOTE**: This Calico sample requires prior external BGP peering — without BGP the CKS deployment will not work as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may refer to line 647-648 how to add a note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @prashanthr2
very good example
just left a minor comment
Corrected note format
Calico sample — require BGP and correct indenting
tested the config internally and it works
📚 Documentation preview 📚: https://cloudstack-documentation--574.org.readthedocs.build/en/574/