Skip to content

Conversation

@MisterRaindrop
Copy link
Collaborator


Change logs

  • adjust DemoTextResolver to serialize multi-column records by joining fields
  • preserve legacy single-field end-of-stream semantics
  • update DemoResolverTest expectation to cover multi-field output

Contributor's checklist

Here are some reminders before you submit your pull request:

  • Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
  • Learn the code contribution and doc contribution guides for better collaboration.
  • List your communications in the GitHub Issues or Discussions (if has or needed).
  • Feel free to ask for the cloudberrydb team to help review and approve.

…le fields

- adjust DemoTextResolver to serialize multi-column records by joining fields
- preserve legacy single-field end-of-stream semantics
- update DemoResolverTest expectation to cover multi-field output
@MisterRaindrop
Copy link
Collaborator Author

MisterRaindrop commented Jan 15, 2026

Hi, can anybody review it? @tuhaihe @Mulily0513 @ostinru

Copy link
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The related external table test passed. LGTM. Wait for others' comments from a technical view.

@Mulily0513
Copy link
Collaborator

LGTM

@ostinru
Copy link
Collaborator

ostinru commented Jan 15, 2026

Adding context - what we are fixing here. Before this patch there were following error in cloudberry-pxf/external-table/results/pxf.out

------------------------------------------------------------------
-- PXF write test
------------------------------------------------------------------
\!rm -rf /tmp/pxf
INSERT INTO pxf_write_test SELECT * from origin;
ERROR:  PXF server error : Unexpected record format, expected 1 field, found 2  (seg0 172.19.0.3:7002 pid=23746)
HINT:  Check the PXF logs located in the '/home/gpadmin/pxf-base/logs' directory on host 'localhost' or 'set client_min_messages=LOG' for additional details.

And PXF logs from /home/gpadmin/pxf-base/logs/pxf-service.log

java.lang.Exception: Unexpected record format, expected 1 field, found 2
        at org.greenplum.pxf.api.examples.DemoTextResolver.setFields(DemoTextResolver.java:63) ~[pxf-api-1.0.0.jar!/:?]
        at org.greenplum.pxf.service.bridge.WriteBridge.setNext(WriteBridge.java:91) ~[classes!/:1.0.0]
        at org.greenplum.pxf.service.controller.WriteServiceImpl.readStream(WriteServiceImpl.java:67) ~[classes!/:1.0.0]
        at org.greenplum.pxf.service.controller.WriteServiceImpl.lambda$writeData$0(WriteServiceImpl.java:40) ~[classes!/:1.0.0]
        at java.security.AccessController.doPrivileged(Native Method) ~[?:?]
        at javax.security.auth.Subject.doAs(Subject.java:361) ~[?:?]

Copy link
Collaborator

@ostinru ostinru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuhaihe
Copy link
Member

tuhaihe commented Jan 15, 2026

Cool! Then let me merge this PR. Thanks all guys!

@tuhaihe tuhaihe merged commit a932ece into apache:merge-with-upstream Jan 15, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants