Let ArrowArrayStreamReader handle schema with attached metadata + do schema checking
#8944
+33
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close? / Rationale for this change
Solves an issue discovered during #8790, namely that
ArrowArrayStreamReaderdoes not correctly expose schema-level metadata and does not check whether theStructArrayconstructed from the FFI stream actually in general corresponds to the expected schema.What changes are included in this PR?
RecordBatchis construted insideArrowArrayStreamReadersuch that it holds metadata and schema validity checks are done.Are these changes tested?
Yes, both
_test_round_trip_exportand_test_round_trip_importnow test for metadata on schema- and column-level.Are there any user-facing changes?
Yes,
ArrowArrayStreamReadernow is able to exportRecordBatchwith schema-level metadata, and the interface has increased security since it actually checks for schema validity.