Return all embeddings for batched OpenAI inputs - #71989
Open
YAshhh29 wants to merge 1 commit into
Open
Conversation
The SDK returns one indexed embedding per batch item, but the hook exposed only the first result. Batch callers therefore received a plausible-looking response with no indication that every later input had been discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The OpenAI Embeddings API accepts batches, but
OpenAIHook.create_embeddings()returned onlyresponse.data[0]. Every successful batch result after the first item was silently discarded.What changed
index.Tests
ruff formatandruff check --fix: passed.git diff --check: passed.The full provider suite was not run locally because Airflow does not support native Windows; CI provides the Linux suite result.
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot following the guidelines
Drafted-by: GitHub Copilot (no human review before posting)