Add Kubernetes-recommended labels to Helm chart - #71987
Open
mihirduvedi wants to merge 2 commits into
Open
Conversation
mihirduvedi
marked this pull request as ready for review
August 23, 2026 03:02
mihirduvedi
requested review from
Miretpl,
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
August 23, 2026 03:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the five Kubernetes-recommended labels from #34048 to chart-managed resources and pod templates. Keep the legacy labels and selectors unchanged so existing workloads, policies, and user queries remain compatible.
Centralize label generation and Kubernetes label-value normalization, preserve user-label precedence, and cover rendered resources, job templates, the KubernetesExecutor pod template, selector preservation, long chart versions, and override behavior.
closes: #34048
Testing:
breeze testing helm-tests --use-xdist --kubernetes-version 1.30.13(2,127 passed)prek run --from-ref upstream/main --stage pre-commitprek run --from-ref upstream/main --stage manualbreeze build-docs helm-chart --one-pass-only(docs and spellcheck)breeze ci selective-check --commit-ref HEADWas generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines
Drafted-by: Codex (GPT-5) (no human review before posting)