Make HttpSensor defer when response_check is provided - #71922
Open
yuseok89 wants to merge 1 commit into
Open
Conversation
yuseok89
force-pushed
the
fix-deferrable-httpsensor-response-check
branch
from
August 22, 2026 16:42
b500a52 to
0ced540
Compare
yuseok89
marked this pull request as ready for review
August 23, 2026 23:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #40209
HttpSensor(deferrable=True)with aresponse_checksilently fell back to the synchronous poke loop, occupying a worker slot for the whole wait. It now defers like any other deferrable sensor: the triggerer waits for the endpoint to respond without error, the check runs on the worker, and if it returns False the task defers again, keeping thepoke_intervalpacing.The callable stays on the worker; only the response is carried back, reusing the JSON serializer already in
triggers/http.py. This is the same patternS3KeySensoruses forcheck_fn.Verified with a live Dag
An
HttpSensor(deferrable=True, poke_interval=20)polling this Airflow's own api-server, with aresponse_checkthat only passes two minutes after the run was triggered.Before the change the task never left
running, since aresponse_checkforced it onto the synchronous path.After the change it goes straight to
deferred, wakes every 20 seconds to evaluate the check on the worker, and succeeds once the check passes:Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.