Skip to content

Remove duplicate otel_* options from [metrics] section - #71351

Open
armorbreak001 wants to merge 1 commit into
apache:mainfrom
armorbreak001:fix/remove-duplicate-otel-metrics-options
Open

Remove duplicate otel_* options from [metrics] section#71351
armorbreak001 wants to merge 1 commit into
apache:mainfrom
armorbreak001:fix/remove-duplicate-otel-metrics-options

Conversation

@armorbreak001

Copy link
Copy Markdown

Summary

Fixes #43366 — Five otel_* configuration options (otel_on, otel_host, otel_port, otel_debugging_on, otel_ssl_active) appear twice in the Configuration Reference documentation: once under [metrics] and once under [traces].

These options were moved from [metrics] to [traces] in commit ccf1202, but the original copies in [metrics] were not removed.

Changes

File: airflow-core/src/airflow/config_templates/config.yml

Removed the 5 duplicate option blocks (79 lines) from the [metrics] section. The canonical versions remain intact in the [traces] section.

The following options were kept in [metrics] (not duplicated in traces):

  • otel_prefix — metrics-specific prefix
  • otel_interval_milliseconds — send interval for metrics
  • otel_service — also present in both sections (left as-is since not mentioned in the issue)

Verification

After this change, searching for each of the 5 removed options in config.yml returns exactly 1 result (the [traces] version) instead of 2.

Fixes apache#43366

The otel_on, otel_host, otel_port, otel_debugging_on, and
otel_ssl_active options were moved to [traces] in ccf1202 but
the copies in [metrics] were not removed, causing them to appear
twice in the Configuration Reference documentation.

This removes the duplicate entries from [metrics], keeping only
the [traces] versions which are the canonical location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Five "otel_*" options appear twice in the "Configuration Reference"

2 participants