Skip to content

Fix misspelled variable in CI migration test DB manager export - #71334

Merged
henry3260 merged 1 commit into
apache:mainfrom
ColtenOuO:fix-ci-migration-tests-db-managers-typo
Aug 8, 2026
Merged

Fix misspelled variable in CI migration test DB manager export#71334
henry3260 merged 1 commit into
apache:mainfrom
ColtenOuO:fix-ci-migration-tests-db-managers-typo

Conversation

@ColtenOuO

Copy link
Copy Markdown
Contributor

Sumarry

Two steps in .github/actions/migration_tests/action.yml reference ${DB_MANGERS}
while the surrounding env: block defines DB_MANAGERS. The variable is undefined,
so the export resolves to AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS= (empty). The
other two steps in the same file spell it correctly.

Nothing fails: GitHub's default shell: bash runs without -u, export X= on its
own line is valid, and the migration commands on the next line run normally — so the
steps have stayed green since the typo was introduced in #50343.

Current impact: none.

Since #62308, RunDBManager starts from DB managers
auto-discovered via provider.yaml, and the FAB provider declares its own, so the
empty config is simply skipped. This is a cleanup: it removes a silent failure that
would come back if discovery were ever not in play, and stops the file contradicting
itself.

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@henry3260
henry3260 merged commit 1f529f3 into apache:main Aug 8, 2026
66 checks passed
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 8, 2026
…xport (apache#71334)

(cherry picked from commit 1f529f3)

Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 8, 2026
…xport (apache#71334)

(cherry picked from commit 1f529f3)

Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
potiuk pushed a commit that referenced this pull request Aug 9, 2026
…xport (#71334) (#71335)

(cherry picked from commit 1f529f3)

Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Aug 13, 2026
…xport (#71334) (#71335)

(cherry picked from commit 1f529f3)

Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants