Instruct AI agents not to include issue tracker in PR title - #71327
Instruct AI agents not to include issue tracker in PR title #71327Prab-27 wants to merge 2 commits into
Conversation
|
I tried to run |
|
Did you try with |
|
@kaxil , I believe I need to change this to the multiagent mode for skill-eval harness since I couldn't run this- don't have claude AI agents or API access here airflow/dev/skill-evals/README.md Line 50 in a37736d The plan : I'd love to raise a PR and ask for review on that Would you please share your thoughts : |
potiuk
left a comment
There was a problem hiding this comment.
Thanks — the rule itself is right and worth documenting.
CI is red on check-eval-hash: AGENTS.md changed, so dev/skill-evals/last-eval-hash.txt needs regenerating. That's the thing you flagged you can't run, and the hook message says so explicitly — a maintainer needs to run prek run run-skill-eval --hook-stage manual --all-files and push the updated hash to this branch. I'll sort that out; nothing for you to do there.
Two things on the content while that happens:
Don't overload the existing bad example. Initialize Dag bundles in CLI get_dag function is there to teach implementation-detail-vs-user-impact. Bolting (#12345) onto it makes one line carry two lessons and dulls both. Please restore that line and add a separate bad example for the tracker id — and mind the missing space before the paren.
Sharpen the reason. The body currently justifies it with "so GitHub auto-links it". The more compelling argument is that GitHub already appends the PR number when squash-merging — our history is full of ... (#71609) — so a hand-written (#12345) duplicates it, and an issue number sitting in that slot reads like a PR number in the changelog. That's the harm worth naming.
Nit: the new paragraph is one long line; the surrounding prose wraps around 100 characters.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Airflow maintainer. The findings
below are observations, not blockers; an Apache Airflow
maintainer — a real person — will take the next look at the
PR. If you think a finding is mis-applied, please reply on
the PR and a maintainer will weigh in.More on how Apache Airflow handles maintainer review:
contributing-docs/05_pull_requests.rst.
Do you have Codex subscription? Since we just merged the Codex one last week. cc @RoyLee1224 who will work on further OpenCode integration. |
|
I ran For the targeted title check, I used the same prompt three times in both arms and explicitly asked the agent to append
The same two eval cases failed in both arms, so there was no regression. Generated hash:
Please rebase before using it, since the hash applies to the latest |
c578db2 to
e527c88
Compare
e527c88 to
7e02f92
Compare
Some PRs title contain issue tracker (#....)
It is good to add instruction - not to include any issue number or anything just add issue tracker only in PR description
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.