Document PostgreSQL fallback host connection strings (#25461) - #69150
Document PostgreSQL fallback host connection strings (#25461)#69150deepujain wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Overall LGTM.
Edit: had to take back my approval due to lack of AI attribution, see below.
@Dev-iL - could you please take a second look? (btw, it seems that other parts of the doc might be outdated as they refer to SQL 1.4 docs, but that could be handled in a separate PR)
Created #69164 for tracking.
|
@deepujain please note that you (or your operator) should include AI attribution in the PR as we state in the AI guidelines. List of PRs: |
0120ba4 to
fa18f8c
Compare
|
Applied the suggestion to avoid making the PostgreSQL fallback-host note specific to Validated locally with Drafted-by: OpenAI Codex (no human review before posting) |
|
@deepujain — There are 1 unresolved review thread(s) on this PR, and you have engaged with each one (post-review commits and/or in-thread replies). Could you confirm whether you believe the feedback is fully addressed and the PR is ready for maintainer review confirmation? If yes, reply here (a short "yes / ready" is fine) and an Apache Airflow maintainer will pick the PR up from the review queue on the next sweep. If you are still working on a thread, please reply with what is outstanding so the threads stay unresolved on purpose. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
|
Yes, ready for maintainer review. The remaining unresolved thread is outdated after the follow-up change: the note now avoids making the fallback-host behavior specific to psycopg2 and refers to PostgreSQL drivers generally, while keeping the SQLAlchemy multiple-host URL reference. No further changes are pending from my side. Drafted-by: OpenAI Codex (no human review before posting) |
fa18f8c to
0791c84
Compare
|
Rebased this branch onto current Drafted-by: OpenAI Codex (no human review before posting) |
0791c84 to
48bf121
Compare
|
Rebased onto current Drafted-by: OpenAI Codex (no human review before posting) |
48bf121 to
f6cbab4
Compare
|
Rebased onto current Drafted-by: OpenAI Codex (no human review before posting) |
f6cbab4 to
c2e0b96
Compare
|
Rebased onto current Drafted-by: OpenAI Codex (no human review before posting) |
c2e0b96 to
24f897b
Compare
|
Rebased onto current Drafted-by: OpenAI Codex (no human review before posting) |
bd74391 to
1d32440
Compare
|
Rebased this branch onto current Drafted-by: OpenAI Codex (no human review before posting) |
1d32440 to
ab11659
Compare
|
Resolved the two outdated review threads whose requested changes were already incorporated, then rebased onto current The file-scoped pre-commit suite for Drafted-by: OpenAI Codex (no human review before posting) |
ab11659 to
c2c8f5f
Compare
|
Rebased onto current The previous head finished with no failed checks. GitHub CI is rerunning for this head. Drafted-by: OpenAI Codex (no human review before posting) |
c2c8f5f to
9c0225c
Compare
|
Rebased onto current The previous head finished with no failed checks. GitHub CI is rerunning for this head. Drafted-by: OpenAI Codex (no human review before posting) |
9c0225c to
b19628a
Compare
|
Rebased onto current The previous head finished with no failed checks. GitHub CI is rerunning for this head. Drafted-by: OpenAI Codex (no human review before posting) |
Title: Document PostgreSQL fallback host connection strings (#25461)
Summary
Document where Airflow users should look when they need PostgreSQL metadata database URLs with multiple fallback hosts. Airflow delegates this URL handling to SQLAlchemy's PostgreSQL dialects, so the setup guidance now points users to SQLAlchemy's current multiple-host syntax instead of leaving them to infer it from the generic PostgreSQL section.
Changes
airflow-core/docs/howto/set-up-database.rst-- add a PostgreSQL note that links to SQLAlchemy's documented multiple fallback host URL format.Evidence it works
psycopg2-specific wording is already applied, so the note now refers to PostgreSQL drivers generally.Test plan
git diff --checkprek run --stage pre-commit --files airflow-core/docs/howto/set-up-database.rstWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines
Fixes #25461