Add researcher profile API and identity linking#486
Open
jayvenn21 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResearcherProfilemodel for researcher-specific metadata attached to an existing Custos userResearcherProfileStoreinterface and MySQL-backed store implementationresearcher_profilesdatabase migration with a one-to-one relationship tousersprofiles,profile_emails, andexternal_identitiestablesNotes
This aligns the researcher profile scaffold with the existing Custos identity model:
usersremains the stable Custos user identityuser_identitiesremains the place for external identities such as ACCESS, NAIRR, CILogon, and ORCIDresearcher_profilesstores additional researcher metadata such as display name, research domain, research capabilities, department, and institutionProject memberships, group memberships, allocations, and publications are intentionally left out of this scaffold because they belong to separate relationship/domain models.
Validation
gofmt -w pkg/models/profile.go internal/store/store.go internal/store/researcher_profile_store.go pkg/service/researcher_profile.go pkg/service/researcher_profile_integration_test.go pkg/service/integration_common_test.go internal/server/server.gogo generate ./pkg/service/...go generate ./cmd/servergo build ./...go vet ./...go test ./...go test -tags=integration ./pkg/service -run 'TestResearcherProfileRoundTrip|TestLinkUserIdentityLinksORCIDToExistingUser'git diff --check