This repository was archived by the owner on Jan 3, 2023. It is now read-only.
requestValue is optional according to RFC 2251 and abandon request support.#6
Open
norox wants to merge 9 commits intoantong:masterfrom
Open
requestValue is optional according to RFC 2251 and abandon request support.#6norox wants to merge 9 commits intoantong:masterfrom
norox wants to merge 9 commits intoantong:masterfrom
Conversation
added unittest and changed assert
One more try
And another one :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Fixed the assert and added a unittest for it, sry for all the extra commits, fucked up with some new stuff that will come in another commit, and did not read carefully enough before I commited again.
Added abandon request support.