Skip to content

Conversation

randombet
Copy link

Current ClaudeSDKClient is base on subprocess and once subprocess is dead or quit unexpectedly. We will lose the session info.
SessionPersistentClient leverages ClaudeSDKClient and auto save and persist session data on local file.

@dicksontsai
Copy link
Collaborator

Thanks for this PR. I think we should just build this resilience into the default ClaudeSDKClient itself by leveraging the resume option. That way, we can avoid having to duplicate the conversation history storage (once here, once within Claude Code)

@randombet
Copy link
Author

Thanks for this PR. I think we should just build this resilience into the default ClaudeSDKClient itself by leveraging the resume option. That way, we can avoid having to duplicate the conversation history storage (once here, once within Claude Code)

By "once within Claude Code", you mean on the server side, right? In that case, we still need session info (e.g session id, cost etc) on client side. LMK what do you think? @dicksontsai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants