You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's possible to annotate the DocString with the type of content it contains. You specify the content type after the triple quote, as follows:
I'm not sure I'm would want to add tool specific comments throughout my feature files - when there is a recommended way of defining the language.
By having this natively in the CLI you don't need additional tools - such as jq. This also doesn't require any dependencies.
Maybe could do a few things to make this more acceptable.
Split the code out a little to keep it a little more readable
Only enable it via a config flag - so it doesn't break backwards compatiability
The idea was to support every format not only JSON, I don't really want to do something only for that, especially keeping both @ thing and this annotation at the same time seems.
It seems better to be able to support any possible docstring and remove the @ mechanism thing and it would be a breaking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be out of scope for this project - happy for this to be rejected!!
This will automatically format json in doc strings using
json.IndentI have run
go test ./...golangci-lint runI agree to the Code of Conduct
Thanks!