Changed some parameters on directive to make their values dynamic.#63
Open
willian wants to merge 1 commit intoangularjs-oauth:masterfrom
Open
Changed some parameters on directive to make their values dynamic.#63willian wants to merge 1 commit intoangularjs-oauth:masterfrom
willian wants to merge 1 commit intoangularjs-oauth:masterfrom
Conversation
Collaborator
|
Would be great to have the following:
Can you make it @willian? |
Collaborator
|
Any possibility to have a test suite on this @willian? It would be really a really nice to have feature. |
|
+1 for parameters on directive |
Member
|
Poke @willian. This PR should be closed otherwise. It's looking rather ancient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my app I have 3 environments:
development,stagingandproduction. Is common to have something like this, and use environment variables or a configuration file per environment to manage some data, like services API's IDs, secrets keys, etc.Passing only string
Using an object
Because of that I changed some parameters to allow me to send a object/variable instead of a plain string.
For now I'm using my own repository, but would be nice to use the original again.
Please, let me know your thoughts about this PR.