(#101) Avoid flicker of login/logout/denied buttons#103
Open
YannDoW wants to merge 1 commit intoangularjs-oauth:masterfrom
Open
(#101) Avoid flicker of login/logout/denied buttons#103YannDoW wants to merge 1 commit intoangularjs-oauth:masterfrom
YannDoW wants to merge 1 commit intoangularjs-oauth:masterfrom
Conversation
Currently, the 3 login, logout and denied buttons are shown before that 2 of them are hidden, which causes an unpleasant flicker. This happens because the AngularJS code takes time to kick-in. Adding the "ng-hide" class to them hide them by default. This way, only the correct button will appear, after a short moment.
Member
|
I believe you are looking to us |
Author
|
Thanks for your answer @bramski ! As I recall (this was last year), I did try to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the 3 login, logout and denied buttons are shown before that 2 of them are hidden, which causes an unpleasant flicker. This happens because the AngularJS code takes time to kick-in.
Adding the "ng-hide" class to them hide them by default. This way, only the correct button will appear, after a short moment.