Internal refactors #32461
Merged
Internal refactors #32461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin and
tjshiu
and removed request for
a team
crisbeto
added
target: minor
It seems like the `_VIEW_REPEATER_STRATEGY` token was introduced as a way to tree shake the different strategies depending on which components are used. While that's true, it also makes the APIs less ergonomic since users have to remember to import additional directives to use them. These changes remove the token in favor of switching the strategy internally which means that we can't tree shake the strategies anymore, but they're relatively small (< 0.5kb minified, not gzipped).
…wport Adds a lightweight token for the virtual scroll viewport so it can be injected without a hard dependency.
crisbeto
force-pushed
the
table-recycle-strategy
branch
from
2c751d6 to
a36fee6
Compare
andrewseguin
approved these changes
Dec 3, 2025
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following internal refactors:
refactor(multiple): remove repeater strategy token
It seems like the
_VIEW_REPEATER_STRATEGYtoken was introduced as a way to tree shake the different strategies depending on which components are used. While that's true, it also makes the APIs less ergonomic since users have to remember to import additional directives to use them.These changes remove the token in favor of switching the strategy internally which means that we can't tree shake the strategies anymore, but they're relatively small (< 0.5kb minified, not gzipped).
refactor(cdk/scrolling): add lightweight token for virtual scroll viewport
Adds a lightweight token for the virtual scroll viewport so it can be injected without a hard dependency.