feat(material/dialog): support async MatDialogConfig.closePredicate #32451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-KRAMA
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
angular-robot
bot
added
detected: feature
Member
|
Aside from the breakages in the build, this is also still a breaking behavior change. The reason we haven't done this ourselves is that by making the callback asynchronous, we can't guarantee the closing order anymore which can come up when opening multiple dialogs on top of each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added async support to closePredicate so dialogs can wait for confirmation or server checks before closing.
The old sync behavior still works.
Tests added for async true and false cases.
All tests pass.
Risk is low and backward compatible.
Fixes issue 32142.