Skip to content

Upgrade to Ink 1.1.0-alpha03#78

Merged
maxmmitchell merged 2 commits into
mainfrom
upgrade-ink-110alpha03
May 27, 2026
Merged

Upgrade to Ink 1.1.0-alpha03#78
maxmmitchell merged 2 commits into
mainfrom
upgrade-ink-110alpha03

Conversation

@maxmmitchell
Copy link
Copy Markdown
Contributor

Motivated by the programmatic APIs, which are now publicly available as of 1.1.0-alpha03. With this change we can migrate existing code to leverage the programmatic APIs for custom brush construction, rather than using proto builders as we do now.

  • Bump AndroidX Ink version to 1.1.0-alpha03, the latest available version as of this PR.
  • Update proto file to latest available version from Ink's open source C++ repo. Not strictly necessary for this version bump, but good to do regularly anyway.
  • Update code where necessary to remove references to the now-nonexistent ExperimentalInkCustomBrushAPI opt-in annotation. Custom brushes are officially out of the experiemental API phase, and so this annotation no longer exists.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ink library dependency from 1.1.0-alpha02 to 1.1.0-alpha03 in gradle/libs.versions.toml. Consequently, the ExperimentalInkCustomBrushApi annotation has been promoted or is no longer required, leading to the removal of its imports and @OptIn annotations across multiple UI and ViewModel files. Additionally, formatting cleanups were applied to DrawingCanvasViewModel.kt, copyright headers were updated in CustomBrushes.kt, and new color function fields (hue_offset_radians, saturation_multiplier, luminosity_offset) along with descriptive comments were added to the brush_family.proto file. I have no feedback to provide on these changes.

@maxmmitchell maxmmitchell marked this pull request as ready for review May 26, 2026 16:07
@maxmmitchell maxmmitchell merged commit 58ca34e into main May 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants