Upgrade to Ink 1.1.0-alpha03#78
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ink library dependency from 1.1.0-alpha02 to 1.1.0-alpha03 in gradle/libs.versions.toml. Consequently, the ExperimentalInkCustomBrushApi annotation has been promoted or is no longer required, leading to the removal of its imports and @OptIn annotations across multiple UI and ViewModel files. Additionally, formatting cleanups were applied to DrawingCanvasViewModel.kt, copyright headers were updated in CustomBrushes.kt, and new color function fields (hue_offset_radians, saturation_multiplier, luminosity_offset) along with descriptive comments were added to the brush_family.proto file. I have no feedback to provide on these changes.
romanofranz
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by the programmatic APIs, which are now publicly available as of
1.1.0-alpha03. With this change we can migrate existing code to leverage the programmatic APIs for custom brush construction, rather than using proto builders as we do now.ExperimentalInkCustomBrushAPIopt-in annotation. Custom brushes are officially out of the experiemental API phase, and so this annotation no longer exists.