Skip to content

Fix image editing sample - #117

Merged
JolandaVerhoef merged 1 commit into
mainfrom
jv/fix-image-editing
Oct 27, 2025
Merged

Fix image editing sample#117
JolandaVerhoef merged 1 commit into
mainfrom
jv/fix-image-editing

Conversation

@JolandaVerhoef

Copy link
Copy Markdown
Collaborator

The masking feature of the image editing sample doesn't work perfectly after the redesign. When masking a portion of the image, after pressing ok when the masking changes to the red color, it moves and doesn't mask the original assigned portion of the image.

This is because of the content scale. I changed it to "FIT" which seems to fix the issue.

…ayed in the correct location.

Change-Id: I2181321d337456c2cc1079225380e6af5ff4831e
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR addresses a bug in the image editing sample where the masking feature was misaligned due to an incorrect contentScale. The fix changes the contentScale of the mask display from Crop to Fit in ImagenEditingScreen.kt to ensure proper alignment.

Highlights

  • Intent: This pull request aims to fix a bug in the image editing sample's masking feature. Specifically, after a redesign, the mask was misaligned or moved from its original position when applied, which was identified as an issue with the contentScale property.
  • Key Changes: The primary change involves modifying the ImagenEditingScreen.kt file. The contentScale property for the Image composable displaying the mask (which is tinted red) has been changed from ContentScale.Crop to ContentScale.Fit. This adjustment is intended to correctly align the mask with the original assigned portion of the image.
  • Reviewer Activity: No specific reviewer activity has been recorded yet for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Thank you for this contribution. Your change to fix the image mask alignment is a good step forward. I've identified one high-severity issue related to this change that needs to be addressed to ensure the fix is complete and robust. Please see my detailed comment below.

@JolandaVerhoef
JolandaVerhoef merged commit bfc180e into main Oct 27, 2025
6 checks passed
@JolandaVerhoef
JolandaVerhoef deleted the jv/fix-image-editing branch October 27, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants