Fix image editing sample - #117
Conversation
…ayed in the correct location. Change-Id: I2181321d337456c2cc1079225380e6af5ff4831e
Summary of ChangesHello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR addresses a bug in the image editing sample where the masking feature was misaligned due to an incorrect Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
Thank you for this contribution. Your change to fix the image mask alignment is a good step forward. I've identified one high-severity issue related to this change that needs to be addressed to ensure the fix is complete and robust. Please see my detailed comment below.
The masking feature of the image editing sample doesn't work perfectly after the redesign. When masking a portion of the image, after pressing ok when the masking changes to the red color, it moves and doesn't mask the original assigned portion of the image.
This is because of the content scale. I changed it to "FIT" which seems to fix the issue.