Skip to content

Fix image editing sample - #116

Closed
JolandaVerhoef wants to merge 28 commits into
mainfrom
jv/improvements
Closed

JolandaVerhoef wants to merge 28 commits into
mainfrom
jv/improvements

Conversation

@JolandaVerhoef

@JolandaVerhoef JolandaVerhoef commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

The masking feature of the image editing sample doesn't work perfectly after the redesign. When masking a portion of the image, after pressing ok when the masking changes to the red color, it moves and doesn't mask the original assigned portion of the image.

This is because of the content scale. I changed it to "FIT" which seems to fix the issue.

lethargicpanda and others added 28 commits October 1, 2025 21:44
Add new ui-component module with some early components.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
Co-authored-by: Thomas Ezan <tezan.enssat@gmail.com>
Co-authored-by: Caren <calren24@gmail.com>
Co-authored-by: calren <5016806+calren@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Thomas Ezan <tezan.enssat@gmail.com>
Co-authored-by: Mayuri Khinvasara <mayuri.k18@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Kateryna Semenova <k.semyonova@gmail.com>
Co-authored-by: lethargicpanda <205574+lethargicpanda@users.noreply.github.com>
Co-authored-by: JolandaVerhoef <6952116+JolandaVerhoef@users.noreply.github.com>
…#102)

Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
Co-authored-by: Caren <calren24@gmail.com>
Co-authored-by: calren <5016806+calren@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Thomas Ezan <tezan.enssat@gmail.com>
Co-authored-by: Mayuri Khinvasara <mayuri.k18@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Kateryna Semenova <k.semyonova@gmail.com>
Co-authored-by: lethargicpanda <205574+lethargicpanda@users.noreply.github.com>
Co-authored-by: JolandaVerhoef <6952116+JolandaVerhoef@users.noreply.github.com>
Improve loading states for:
- Gemini Chatbot
- Gemini Image Chatbot
- Imagen
- Magic selfie
…ayed in the correct location.

Change-Id: I2181321d337456c2cc1079225380e6af5ff4831e
@google-cla

google-cla Bot commented Oct 7, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant UI/UX overhaul by introducing a dedicated ui-component module. This module centralizes shared UI elements, themes, and typography, ensuring a consistent design language across all AI samples. The changes involve migrating existing UI logic into reusable components, updating all sample screens to adopt these new components, and enhancing the main catalog's presentation. This refactoring aims to improve maintainability, reduce code duplication, and provide a more polished user experience.

Highlights

  • New UI Component Module: A new ui-component module has been introduced to centralize common UI elements, themes, and typography, promoting consistency and reususability across the application.
  • Refactored Sample Screens: All individual sample screens have been updated to utilize the new ui-component module, streamlining their UI implementation and ensuring a unified look and feel.
  • Enhanced Sample Catalog Display: The main CatalogApp now features new CatalogWideCard and CatalogRowCard components, allowing for richer presentation of samples, including featured items and key art.
  • Improved Top App Bar: The application now uses a TwoRowsTopAppBar with dynamic behavior, providing a more modern and informative header for both the main catalog and individual sample details.
  • Dependency and Resource Cleanup: Obsolete theme files, launcher icons, and redundant UI component files have been removed, simplifying the project structure and reducing bloat.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and impressive UI overhaul across the entire application. Key improvements include:

  • Centralized UI Components: A new :ui-component module has been created to house shared UI elements like buttons, text inputs, and the app theme. This greatly improves code reusability and ensures a consistent look and feel.
  • Modernized UI/UX: Many screens have been refactored to use these new components, resulting in a more polished and modern user experience. This includes new list item cards, responsive layouts for different screen sizes, and improved top app bars.
  • Code Quality and Architecture: The refactoring adheres to best practices, such as separating stateful and stateless composables and improving state management within ViewModels. The project structure has also been improved by better separating domain and UI layers.
  • Dependency Updates: Several dependencies have been updated to their latest versions.

Overall, this is an excellent update that significantly enhances the application's maintainability and visual appeal. I have found one critical issue regarding a duplicated entry in the sample catalog that needs to be addressed.

Comment on lines +136 to 144
SampleCatalogItem(
title = R.string.gemini_video_metadata_creation_sample_title,
description = R.string.gemini_video_metadata_creation_sample_description,
route = "VideoMetadataCreationScreen",
sampleEntryScreen = { VideoMetadataCreationScreen() },
tags = listOf(SampleTags.GEMINI_FLASH, SampleTags.FIREBASE, SampleTags.MEDIA3),
needsFirebase = true,
keyArt = R.drawable.img_keyart_video_summary,
),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This SampleCatalogItem for "Video Metadata Creation" appears to be a duplicate of the one immediately preceding it. This will create a redundant entry in the catalog list and may cause navigation issues since they share the same route. Please remove this duplicated block.

@JolandaVerhoef
JolandaVerhoef changed the base branch from main to redesign October 8, 2025 09:43
@JolandaVerhoef JolandaVerhoef changed the title jv/improvements Fix image editing sample Oct 8, 2025
Base automatically changed from redesign to main October 8, 2025 09:52
@JolandaVerhoef
JolandaVerhoef deleted the jv/improvements branch October 8, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants