Fix image editing sample - #116
JolandaVerhoef wants to merge 28 commits into
Conversation
Add new ui-component module with some early components.
Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
Co-authored-by: Thomas Ezan <tezan.enssat@gmail.com>
Co-authored-by: Caren <calren24@gmail.com> Co-authored-by: calren <5016806+calren@users.noreply.github.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Thomas Ezan <tezan.enssat@gmail.com> Co-authored-by: Mayuri Khinvasara <mayuri.k18@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Kateryna Semenova <k.semyonova@gmail.com> Co-authored-by: lethargicpanda <205574+lethargicpanda@users.noreply.github.com> Co-authored-by: JolandaVerhoef <6952116+JolandaVerhoef@users.noreply.github.com>
…#102) Co-authored-by: Jolanda Verhoef <JolandaVerhoef@users.noreply.github.com>
Co-authored-by: Caren <calren24@gmail.com> Co-authored-by: calren <5016806+calren@users.noreply.github.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Thomas Ezan <tezan.enssat@gmail.com> Co-authored-by: Mayuri Khinvasara <mayuri.k18@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Kateryna Semenova <k.semyonova@gmail.com> Co-authored-by: lethargicpanda <205574+lethargicpanda@users.noreply.github.com> Co-authored-by: JolandaVerhoef <6952116+JolandaVerhoef@users.noreply.github.com>
Improve loading states for: - Gemini Chatbot - Gemini Image Chatbot - Imagen - Magic selfie
…ayed in the correct location. Change-Id: I2181321d337456c2cc1079225380e6af5ff4831e
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant UI/UX overhaul by introducing a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and impressive UI overhaul across the entire application. Key improvements include:
- Centralized UI Components: A new
:ui-componentmodule has been created to house shared UI elements like buttons, text inputs, and the app theme. This greatly improves code reusability and ensures a consistent look and feel. - Modernized UI/UX: Many screens have been refactored to use these new components, resulting in a more polished and modern user experience. This includes new list item cards, responsive layouts for different screen sizes, and improved top app bars.
- Code Quality and Architecture: The refactoring adheres to best practices, such as separating stateful and stateless composables and improving state management within ViewModels. The project structure has also been improved by better separating domain and UI layers.
- Dependency Updates: Several dependencies have been updated to their latest versions.
Overall, this is an excellent update that significantly enhances the application's maintainability and visual appeal. I have found one critical issue regarding a duplicated entry in the sample catalog that needs to be addressed.
| SampleCatalogItem( | ||
| title = R.string.gemini_video_metadata_creation_sample_title, | ||
| description = R.string.gemini_video_metadata_creation_sample_description, | ||
| route = "VideoMetadataCreationScreen", | ||
| sampleEntryScreen = { VideoMetadataCreationScreen() }, | ||
| tags = listOf(SampleTags.GEMINI_FLASH, SampleTags.FIREBASE, SampleTags.MEDIA3), | ||
| needsFirebase = true, | ||
| keyArt = R.drawable.img_keyart_video_summary, | ||
| ), |
There was a problem hiding this comment.
The masking feature of the image editing sample doesn't work perfectly after the redesign. When masking a portion of the image, after pressing ok when the masking changes to the red color, it moves and doesn't mask the original assigned portion of the image.
This is because of the content scale. I changed it to "FIT" which seems to fix the issue.