Skip to content

[e2e] encryption key related dtos - #64

Open
capcom6 wants to merge 1 commit into
masterfrom
e2e/encryption-key-dtos
Open

[e2e] encryption key related dtos#64
capcom6 wants to merge 1 commit into
masterfrom
e2e/encryption-key-dtos

Conversation

@capcom6

@capcom6 capcom6 commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Devices and mobile operations now support optional public encryption keys and key-version metadata.
    • Phone number fields now accept values up to 512 characters, accommodating longer formats.
  • Documentation
    • Expanded documentation covering available features, error handling, client configuration, and client API usage.
    • Added details about message cancellation, message and inbox listing, and inbox refresh capabilities.
    • Added contact and acknowledgments information and updated the table of contents.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
smsgateway/domain_messages.go 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@capcom6, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01fa853a-93b6-430b-8c36-49a8d3947931

📥 Commits

Reviewing files that changed from the base of the PR and between ef4aef6 and 27de6c9.

📒 Files selected for processing (1)
  • README.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5824ecb5-6f17-4095-8686-bf7ac9605b99

📥 Commits

Reviewing files that changed from the base of the PR and between c3143ac and ef4aef6.

📒 Files selected for processing (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

📝 Walkthrough

Walkthrough

The change adds reusable versioned public-key metadata to device and mobile request models. It increases phone-number validation limits and expands README coverage for features, errors, configuration, APIs, contacts, and acknowledgments.

Changes

Client model and documentation updates

Layer / File(s) Summary
Device and mobile key contracts
smsgateway/domain_devices.go, smsgateway/requests_mobile.go
Adds optional public-key and key-version fields through VersionedPublicKey. Device and mobile request types use the shared embedded model.
Phone-number validation limits
smsgateway/domain_messages.go
Increases the maximum length for Message.PhoneNumbers entries and RecipientState.PhoneNumber from 128 to 512 characters.
Client documentation
README.md
Documents features, error handling, client configuration, API methods, contact links, and acknowledgments.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding DTOs for versioned encryption public keys.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@capcom6
capcom6 force-pushed the e2e/encryption-key-dtos branch 3 times, most recently from 15eb653 to 9406469 Compare July 31, 2026 07:48
@capcom6
capcom6 marked this pull request as ready for review August 4, 2026 00:57
@capcom6 capcom6 added the ready label Aug 4, 2026
@capcom6
capcom6 force-pushed the e2e/encryption-key-dtos branch 2 times, most recently from 70d0ce6 to 001d392 Compare August 10, 2026 02:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 185-192: Add the missing
github.com/android-sms-gateway/client-go/rest import to the README Go example
containing rest.IsBadRequest and rest.IsServerError, or explicitly mark the
snippet as a continuation if imports are intentionally omitted.
- Line 216: Update the README text describing Config.Validate() to state that
validation requires at least one non-empty authentication value and explicitly
accepts partial Basic Auth credentials.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: de308ae3-ab3b-4adf-a039-b93342027f15

📥 Commits

Reviewing files that changed from the base of the PR and between 70d0ce6 and c3143ac.

📒 Files selected for processing (2)
  • README.md
  • smsgateway/domain_devices.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • smsgateway/domain_devices.go

Comment thread README.md Outdated
Comment thread README.md Outdated
@capcom6
capcom6 force-pushed the e2e/encryption-key-dtos branch from ef4aef6 to 27de6c9 Compare August 18, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant