Skip to content

autoplay if autoplay prop passed #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

autoplay if autoplay prop passed #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a85efa
autoplay if autoplay prop passed
aquaminer Oct 27, 2020
d7cc3e4
fix tests
aquaminer Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/VueLazyYoutubeVideo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ export default (Vue as WithRefs<Refs, WithEvents<Events>>).extend({
},
srcAttribute(): string {
const hasQuestionMark = this.src.indexOf('?') !== -1
const src = `${this.src}${hasQuestionMark ? '&' : '?'}autoplay=1${
const src = `${this.src}${hasQuestionMark ? '&' : '?'}${
this.autoplay ? 'autoplay=1' : ''
}${
this.enablejsapi ? '&enablejsapi=1' : ''
}`

Expand Down
6 changes: 3 additions & 3 deletions test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ describe('VueLazyYoutubeVideo', () => {
let wrapper = TestManager.createWrapper()
let iframe = await TestManager.clickAndGetIframe(wrapper)
expect(iframe.element.getAttribute('src')).toBe(
`${defaultProps.src}?autoplay=1`
`${defaultProps.src}`
)
const query = '?loop=1'
wrapper = TestManager.createWrapper({
propsData: getDefaultProps({ query }),
})
iframe = await TestManager.clickAndGetIframe(wrapper)
expect(iframe.element.getAttribute('src')).toBe(
`${defaultProps.src}${query}&autoplay=1`
`${defaultProps.src}${query}`
)
})

Expand Down Expand Up @@ -487,7 +487,7 @@ describe('VueLazyYoutubeVideo', () => {
})
const iframe = await TestManager.clickAndGetIframe(wrapper)
expect(iframe.element.getAttribute('src')).toBe(
`${defaultProps.src}?autoplay=1&rel=0&color=white`
`${defaultProps.src}?rel=0&color=white`
)
})

Expand Down