Open
Conversation
Owner
|
I, sorry I somehow missed this PR. Could you please rebase/retest it? The change also needs integration tests. |
Contributor
Author
|
I've added an integration test, and it passed the test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to boot with virtiofs as rootfs, the behaviour stays in-line with
mkinitcpioanddracut, in thatrootfstype=virtiofsmust be specified explicitly to distinguish it from other "virtual" roots (e.g. virtio-9p, nfs, etc), e.g.rootfstype=virtiofs root=root(Of course this only adds support of virtiofs)
virtiofs is a nice host-passthrough "fs" with which a virtual machine can use the host fs almost directly, saving the overhead of "guest fs -> guest disk -> host file -> host fs" hassle, a virtiofs root is especially useful when access to files in guest root fs from host directly is needed, e.g. when doing frequent debugging, or vice versa.
E.g. with the following snippet in corresponding libvirt-qemu config:
And an Arch system installed in archiso with the following steps:
With optionally the following fstab:
The guest os can be booted with the following libvirt-qemu snippet:
Booting is successful with this patchset: