Unlock pydantic version #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library freezes pydantic to version 2.5.3, which is a major no no.
It's well accept protocol not to lock in versions of dependencies, but rather to specify lax lower bounds you're confident will vaguely work. I'm not sure what that version is but I'll assume it's 2.5.3 see as that's what it's been set as.
The reason is that anyone (today, that's me) upgrading a large project to pydantic v2 will be unable to do so if one of its dependencies requires pydantic > 2.5.3, all because someone used
pydantic2-argparsein one small corner of the project even if that's barely used, because of the way poetry checks version compatibility.