play a file from the shared file tab - #278
Conversation
|
Thanks @tbo47 — this addresses most of the #272 points: the preview logic is now a single shared A few things before it can go in: 1. Gate Play/Open to the monolithic app — on both tabs. The new Shared-tab item ( 2. Guard the downcast. 3. Replace the 4. Label it "Open" on the Shared tab and route by file type — aMule already has the helper. The Shared list is arbitrary files, not just media, so a completed file should say "Open". Right now the configured video player is forced on every type, so "Play" on a non-media file (a 5. The po diff. The large catalog churn is because your branch predates recent string additions on master — the |
got3nks's review of amule-org#650 asked for this to reach amulegui and amuleapi, not just the monolithic app, ahead of the push to keep every feature available across all three clients. Adds two optional EC_TAG_CONNSTATE sub-tags, hand-synced into ECCodes.abstract/.h per the project's existing convention (never regenerate the committed header -- it reflows the whole license block): - EC_TAG_ED2K_CONNECTED_SINCE / EC_TAG_KAD_CONNECTED_SINCE (uint32 unix timestamps), populated in CEC_ConnState_Tag's constructor from CamuleApp's existing m_ed2kConnectedSince/m_kadConnectedSince, present only while actually connected. Consumption side: - CamuleRemoteGuiApp (amulegui) gets matching m_ed2kConnectedSince/ m_kadConnectedSince members and GetED2KConnectedSince()/ GetKadConnectedSince() accessors -- same names as CamuleApp's, so ServerWnd.cpp's "Connected since" rows no longer need a #ifndef CLIENT_GUI gate; each build's theApp resolves to whichever class actually has the data. - amuleapi's Refresher.cpp reads the same sub-tags directly into StatusSnapshot.{ed2k,kad}_connected_since, surfaced in GET /status as ed2k.connected_since / kad.connected_since (0 while disconnected). Documented in docs/api/REFERENCE.md. po/ catalogs regenerated as the final step (scripts/update-po.sh) so the diff is just the "Connected since:" string in sync with the tree, per got3nks's note on amule-org#278 about avoiding line-number-shift churn. Verified by building and running all three targets (amule, amulegui, amuleapi) plus the full unit test suite (26/26 passing, including RefresherTest which exercises the new StatusSnapshot fields directly).
Summary
Play a file from the shared file tab.
I tried to use the feedback from
#272