Few ideas for fluentRevealNavbar.uc.js#77
Few ideas for fluentRevealNavbar.uc.js#77emvaized wants to merge 33 commits intoaminomancer:masterfrom
Conversation
aminomancer
left a comment
There was a problem hiding this comment.
Pretty neat, thanks. I have some feedback, mostly nitpicks.
| if (el.disabled) { | ||
| return this.clearEffect(area); | ||
| } | ||
|
|
There was a problem hiding this comment.
The code below needs to be fixed, or there is a bug when you move the mouse around the top of the page on about:config or about:preferences, etc. It's because they are in the parent process so their true event targets pass all the way up to the chrome window listener (normally the event target we see would be <browser>).
It's better if we just use MousePosTracker.
let x = MousePosTracker._x - this.getOffset(area).left - window.scrollX;
let y = MousePosTracker._y - this.getOffset(area).top - window.scrollY;There was a problem hiding this comment.
Sorry, I didn't know about this bug, so my first thought was this check was added just for UX convenience. So now this should be handled by new getComputedStyle(el).pointerEvents == "none" check, right?
aminomancer
left a comment
There was a problem hiding this comment.
Looks pretty good, there is still some minor cleanup to do though
This PR:
pointerEvents=noneon navbar button, which resulted in script not working for me on FF 115filterDy, which don't process mouse movements greater than {gradientSize}px from top of the screen, in order to reduce system load (default: true)cacheButtons, which stores all toolbar buttons on script init and then reuses the list on each draw iteration (default: false)includeUrlBar, which applies effect to url bar as well (when it's not focused) (default: true)