Repository navigation
Refactor BinaryPrimitiveReader and FlexInt - #1129
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ion11 #1129 +/- ##
========================================
Coverage ? 68.72%
Complexity ? 6051
========================================
Files ? 194
Lines ? 24769
Branches ? 4340
========================================
Hits ? 17023
Misses ? 6423
Partials ? 1323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgregg
approved these changes
Oct 17, 2025
austnwil
reviewed
Oct 17, 2025
austnwil
left a comment
austnwil
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. One consistency thing: the Fixed(U)Int reader functions are modeled as extensions on ByteArray, while the Flex(U)Int reader functions accept the ByteArray as a parameter. Might be worth picking one or the other
Contributor
Author
|
I will deal with the naming consistency in my next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Cleans up BinaryPrimitiveReader and FlexInt so that they don't have competing concerns.
bytecode.BinaryPrimitiveReadertobytecode.bin11.bytearray.PrimitiveDecoderFlexInttoPrimitiveEncoderFlexIntto the newPrimitiveDecoderPrimitiveTestCases_1_1that has shared method sources of test cases for reading/writing FlexInts and FlexUInts.Unfortunately, the diff on github makes it look like
FlexIntwas renamed toPrimitiveDecoderbecause of all of the code that was moved.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.