Repository navigation
Update bytecode and add test utilities - #1111
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ion11 #1111 +/- ##
========================================
Coverage ? 68.07%
Complexity ? 5711
========================================
Files ? 180
Lines ? 23821
Branches ? 4230
========================================
Hits ? 16217
Misses ? 6303
Partials ? 1301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
austnwil
left a comment
There was a problem hiding this comment.
Looks good! Thanks again for those convenience methods
| SYMBOL_SID $23 | ||
| FLOAT_F32 | ||
| 3.1415 | ||
| SYMBOL_SID $24 | ||
| INT_I16 42 |
There was a problem hiding this comment.
Should these be contained in s-expressions?
There was a problem hiding this comment.
The S-Expressions are for human readability more than anything else. If you think that we should keep the S-Expressions in the bytecode, we can, but it's not strictly necessary to make things work.
There was a problem hiding this comment.
Got it, let's keep the bytecode as lean as possible.
Issue #, if available:
None
Description of changes:
(space) after instructions with no packed data.ByteArrayIMPORTinstruction to the bytecodeBytecodeGeneratorBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.