Repository navigation
Adds Macro APIs - #1105
Merged
Merged
Adds Macro APIs#1105
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ion11 #1105 +/- ##
========================================
Coverage ? 68.07%
Complexity ? 5709
========================================
Files ? 181
Lines ? 23816
Branches ? 4228
========================================
Hits ? 16212
Misses ? 6304
Partials ? 1300 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgregg
approved these changes
Oct 8, 2025
|
|
||
| fun writeTaglessPlaceholder(taglessEncodingOpcode: Int) | ||
|
|
||
| fun stepInDirective(directive: Int) {} |
Contributor
Author
There was a problem hiding this comment.
I wasn't sure after what we learned about ints vs enums in IonCursorBinary. Since it's the raw writer, I think that ints are okay here, but I need to add proper documentation before I merge the PR.
| fun writeClob(value: ByteArray) = writeClob(value, 0, value.size) | ||
| fun writeClob(value: ByteArray, start: Int, length: Int) | ||
|
|
||
| fun stepInTaglessElementList(type: Int) |
tgregg
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None.
Description of changes:
Macrointerface, along with an implementation, with a fluent builder for creating the template body.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.