feat(Bank Reconciliation): add manual FX reconcile flow for cross-currency vouchers#343
Open
barredterra wants to merge 7 commits intoversion-15-hotfixfrom
Open
feat(Bank Reconciliation): add manual FX reconcile flow for cross-currency vouchers#343barredterra wants to merge 7 commits intoversion-15-hotfixfrom
barredterra wants to merge 7 commits intoversion-15-hotfixfrom
Conversation
…rency vouchers Enable reconcile-time manual conversion when a selected voucher currency differs from the bank transaction by adding a guarded conversion dialog with server-prefilled context. Update Payment Entry and matching logic to validate and cap manual amounts, apply user-approved exchange rates, and prioritize same-currency matches while still allowing cross-currency candidates.
since we added currency ranking, this has increased by 1
2b7cdc6 to
29b43e6
Compare
0xD0M1M0
reviewed
Feb 13, 2026
banking/public/js/bank_reconciliation_beta/actions_panel/reconcile_conversion_dialog.js
Show resolved
Hide resolved
banking/public/js/bank_reconciliation_beta/actions_panel/reconcile_conversion_dialog.js
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable reconcile-time manual conversion when a selected voucher currency differs from the bank transaction by adding a guarded conversion dialog with server-prefilled context. Update Payment Entry and matching logic to validate and cap manual amounts, apply user-approved exchange rates, and prioritize same-currency matches while still allowing cross-currency candidates.
Resolves #340