crypto optionality for async module + market hours feed async to be iex as a default#648
Open
silvervadim wants to merge 4 commits intoalpacahq:masterfrom
Open
crypto optionality for async module + market hours feed async to be iex as a default#648silvervadim wants to merge 4 commits intoalpacahq:masterfrom
silvervadim wants to merge 4 commits intoalpacahq:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi I originally had a contribution for the rest_async module to have a crypto option. It passed all of the tests but was delayed approval for a month after Rahul asked to review it (I'm still waiting on that). I closed the earlier pull request and just combined that with this one. Please let me know if you can approve this since I am working on a package I would like to deploy to PyPI