Fix issue where self._streams set is used as channels but cannot be s…#398
Open
briangu wants to merge 2 commits intoalpacahq:masterfrom
Open
Fix issue where self._streams set is used as channels but cannot be s…#398briangu wants to merge 2 commits intoalpacahq:masterfrom
briangu wants to merge 2 commits intoalpacahq:masterfrom
Conversation
|
CAN WE GET THIS MERGED!!! This is because Alpaca API gets disconnected midway. So the API tries to reconnect. But when it does so, the channels are not reinitialized, hence it remains a set that is not JSON serializable. Hence, in alpaca_trade_api > stream2.py change 'streams': channels to 'streams': list(channels) in line 132. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where self._streams set is used as channels but cannot be serialized.
When the websocket restarts due to closure, self._streams is used as channels but since it is a set, it cannot be serialized:
at alpaca-trade-api-python/alpaca_trade_api/stream2.py:100> exception=TypeError('Object of type set is not JSON serializable')>
Traceback (most recent call last):
File "/scm/alpaca-trade-api-python/alpaca_trade_api/stream2.py", line 108, in _ensure_ws
await self.subscribe(self._streams)
File "/scm/alpaca-trade-api-python/alpaca_trade_api/stream2.py", line 124, in subscribe
await self._ws.send(json.dumps({
File "/usr/local/lib/python3.9/json/init.py", line 231, in dumps
return _default_encoder.encode(obj)
File "/usr/local/lib/python3.9/json/encoder.py", line 199, in encode
chunks = self.iterencode(o, _one_shot=True)
File "/usr/local/lib/python3.9/json/encoder.py", line 257, in iterencode
return _iterencode(o, 0)
File "/usr/local/lib/python3.9/json/encoder.py", line 179, in default
raise TypeError(f'Object of type {o.class.name} '
TypeError: Object of type set is not JSON serializable